Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: Fix PATH escaping #58551

Merged
merged 1 commit into from Mar 29, 2019
Merged

bazel: Fix PATH escaping #58551

merged 1 commit into from Mar 29, 2019

Conversation

infinisil
Copy link
Member

Motivation for this change

Fixes #58516

Ping @dicarlo2 @Profpatsch (original author of this line)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Profpatsch
Copy link
Member

Wasn’t meeee, I just refactored iirc. Goood catch though.

@infinisil
Copy link
Member Author

infinisil commented Mar 29, 2019 •
edited

Ah :3

Original author is therefore @kalbasit in 9c5b7cc (#44079) :)

@Profpatsch Profpatsch merged commit 555734e into NixOS:master Mar 29, 2019
@infinisil infinisil deleted the fix/bazel-path branch March 29, 2019 19:36
@dicarlo2
Copy link

Awesome, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@infinisil @Profpatsch @dicarlo2 @GrahamcOfBorg