Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stellarium: 0.18.3 -> 0.19.0 #58503

Merged
merged 1 commit into from Mar 29, 2019
Merged

stellarium: 0.18.3 -> 0.19.0 #58503

merged 1 commit into from Mar 29, 2019

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Mar 28, 2019

Motivation for this change

Update stellarium to current version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg requested review from peti and Ma27 March 28, 2019 20:35
@Ma27
Copy link
Member

Ma27 commented Mar 29, 2019

Also built and tested locally 👍

@Ma27 Ma27 merged commit 54e77d5 into NixOS:master Mar 29, 2019
@Ma27
Copy link
Member

Ma27 commented Mar 29, 2019

@geistesk thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxzi @Ma27 @GrahamcOfBorg