Haskell optional separate bin output #58525
Conversation
Spares compilation time by not compiling the package twice.
|
Is there a reason we wouldn't want this on by default? |
|
It's a deeeep rabbit hole to get all packages to build. That's why the PR was stuck for 2 years, let's ship infrastructure first and then do the default switch separately. |
|
I'm going to merge this as it's a new toggle defaulting to old behaviour. Feel free to review it regardless and I'll address the comments. |
|
@domenkozar, it really sucks that you merge this kind of change without giving me (and others) any chance at all to review it first. This is quite anti-social behavior, IMHO, and I am very disappointed because you should know better. |
|
@shlevy reviewed it? |
|
Very funny. |
| @@ -94,6 +94,8 @@ self: super: builtins.intersectAttrs super { | |||
| # Won't find it's header files without help. | |||
| sfml-audio = appendConfigureFlag super.sfml-audio "--extra-include-dirs=${pkgs.openal}/include/AL"; | |||
|
|
|||
| cachix = enableSeparateBinOutput super.cachix; | |||
There was a problem hiding this comment.
Think this should be in configuration-nix?
There was a problem hiding this comment.
I'm not sure, could be also in common?
|
https://github.com/input-output-hk/nix-tools building components separately makes me happy because then there are no |
|
@Ericson2314 planning to switch to that soon but since this was a low hanging fruit it was really useful :) |
The first commit adds most minimal separate output support (by not trigger recompilation on generic builder).
The second commit proves it's already useful.