Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: lists: Alias map = builtins.map #58537

Merged
merged 1 commit into from Mar 29, 2019
Merged

Conversation

matthiasbeyer
Copy link
Contributor

Suggested by @Profpatsch (added in trailer in commit message)

Motivation for this change

We really should have an alias here for consistency.

@matthiasbeyer
Copy link
Contributor Author

Whops. I have to rewrite that commit!

@matthiasbeyer
Copy link
Contributor Author

Now this looks good. Don't want my work-email in the commit message, you know.

@infinisil
Copy link
Member

You can just add it to the list of inherits in line 10 instead

@Profpatsch
Copy link
Member

I like the bit of documentation, it adds consistency.

@Profpatsch
Copy link
Member

I’d move it up below singleton.

@matthiasbeyer
Copy link
Contributor Author

I like the bit of documentation, it adds consistency.

That bit is gone now with the inherit variant suggested by @infinisil 😄

@matthiasbeyer
Copy link
Contributor Author

I'll do a fixup-rebase if one or more reviewers ack this patch.

@infinisil
Copy link
Member

@Profpatsch
Copy link
Member

Ah, you mean the documentation that is in a totally different document and covers about 30% of all builtins? :)

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Suggested-by: Profpatsch <mail@profpatsch.de>
@infinisil infinisil merged commit 84067b7 into NixOS:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants