Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sumatools: init at 1.0.34 #58534

Merged
merged 1 commit into from Apr 24, 2019
Merged

sumatools: init at 1.0.34 #58534

merged 1 commit into from Apr 24, 2019

Conversation

bzizou
Copy link
Contributor

@bzizou bzizou commented Mar 29, 2019

Motivation for this change

Application developed by my research laboratory and used into our computing center

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse requested changes Apr 12, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few nitpicks

pkgs/applications/science/biology/sumatools/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/sumatools/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/biology/sumatools/default.nix Outdated Show resolved Hide resolved
@risicle
Copy link
Contributor

risicle commented Apr 13, 2019 •
edited

Hmm I get fixed-output derivation produced path '/nix/store/jgavavhmpl2bwqkx7gs45zx99l7jm7fa-source' with sha256 hash '1bbpbdkshdc3xffqnr1qfy8qk64ldsmdc3s8mrcrlx132rgbi5f6' instead of the expected hash '0hwkrxzfz7m5wdjvmrhkjg8kis378iaqr5n4nhdhkwwhn8x1jn5a'

Someone been force-pushing?

@bzizou
Copy link
Contributor Author

bzizou commented Apr 19, 2019

Well, I think, that I forced-pushed the wrong branch (I have one still having 4 spaces indentation...) Let me check and fix this...

@bzizou
Copy link
Contributor Author

bzizou commented Apr 19, 2019

Should be ok this time.

c0bw3b
c0bw3b approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed local nix-review on NixOS

@c0bw3b c0bw3b merged commit 71c6157 into NixOS:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse requested changes

@symphorien symphorien symphorien left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bzizou @risicle @aanderse @symphorien @c0bw3b @GrahamcOfBorg