Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clblas: turn of gtest, fix build #58536

Merged
merged 2 commits into from Mar 29, 2019
Merged

clblas: turn of gtest, fix build #58536

merged 2 commits into from Mar 29, 2019

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Mar 29, 2019 •
edited

Motivation for this change

clblas does not work anymore with gmock 1.8.1.
Turning off the test suite does not seem to be the best solution but fixes the build.

See #58427

Should be back ported to 19.03 (#56826)

CC @artuuge

Things done
  • Remove gtest from derivation
  • fix libgpuarray build, which depends on clblas
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
clblas: turn of gtest, fix build
4c74ee9 
clblas does not work anymore with gmock 1.8.1.
Turning off the test suite fixes the build.
@markuskowa
libgpuarray: fix build
ad1e7b0 
move cmake into nativeBuildInputs
@markuskowa markuskowa requested a review from FRidh as a code owner March 29, 2019 13:21
@markuskowa
Copy link
Member Author

@GrahamcOfBorg build python37Packages.libgpuarray

@infinisil
Copy link
Member

builder for '/nix/store/brdird0l0k28iy4f3lr23xda3lpiidb6-openblas-0.3.5.drv' failed with exit code 2

On aarch, so just a dependency failing, so we can ignore that

@infinisil infinisil merged commit 106b52b into NixOS:master Mar 29, 2019
@infinisil
Copy link
Member

Cherry-picked to 19.03 in d3634b0 (and parent)

@markuskowa markuskowa deleted the fix-clblas branch March 29, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @infinisil @GrahamcOfBorg