Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitaly: Run gitaly with procps in scope #58487

Merged
merged 1 commit into from Mar 28, 2019
Merged

gitaly: Run gitaly with procps in scope #58487

merged 1 commit into from Mar 28, 2019

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Mar 28, 2019

Motivation for this change

Gitaly uses ps to track the RSS of gitlab-ruby and kills it when it
detects excessive memory leakage. See
https://gitlab.com/gitlab-org/gitaly/issues/1562.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bgamari
nixos/gitaly: Run gitaly with procps in scope
b90f5f0 
Gitaly uses `ps` to track the RSS of `gitlab-ruby` and kills it when it
detects excessive memory leakage. See
https://gitlab.com/gitlab-org/gitaly/issues/1562.
@bgamari bgamari requested a review from infinisil as a code owner March 28, 2019 14:49
@infinisil infinisil merged commit be2f711 into NixOS:master Mar 28, 2019
@infinisil
Copy link
Member

infinisil commented Mar 28, 2019 •
edited

Backported to 19.03 in e6cba7b
Backported to 18.09 in 2ec3dca

yayayayaka added a commit to yayayayaka/nixpkgs that referenced this pull request May 24, 2023
@yayayayaka
nixos/gitlab: Remove procps from gitaly service
5842667 
From my understanding, procps was added to the gitlay systemd service
path in NixOS#58487 to fix gitaly-ruby's internal memory leak detection.

Now that the last ruby remnants have been removed in gitaly 16.0.0,
this should not be necessary anymore.
yu-re-ka pushed a commit to yayayayaka/nixpkgs that referenced this pull request May 25, 2023
@yayayayaka @yu-re-ka
nixos/gitlab: Remove procps from gitaly service
804a516 
From my understanding, procps was added to the gitlay systemd service
path in NixOS#58487 to fix gitaly-ruby's internal memory leak detection.

Now that the last ruby remnants have been removed in gitaly 16.0.0,
this should not be necessary anymore.
yayayayaka added a commit to yayayayaka/nixpkgs that referenced this pull request May 25, 2023
@yayayayaka
nixos/gitlab: Remove procps from gitaly service
f817dbf 
From my understanding, procps was added to the gitlay systemd service
path in NixOS#58487 to fix gitaly-ruby's internal memory leak detection.

Now that the last ruby remnants have been removed in gitaly 16.0.0,
this should not be necessary anymore.
yayayayaka added a commit to yayayayaka/nixpkgs that referenced this pull request May 30, 2023
@yayayayaka
nixos/gitlab: Remove procps from gitaly service
17398d4 
From my understanding, procps was added to the gitlay systemd service
path in NixOS#58487 to fix gitaly-ruby's internal memory leak detection.

Now that the last ruby remnants have been removed in gitaly 16.0.0,
this should not be necessary anymore.
yayayayaka added a commit to yayayayaka/nixpkgs that referenced this pull request May 30, 2023
@yayayayaka
nixos/gitlab: Remove procps from gitaly service
e639c44 
From my understanding, procps was added to the gitlay systemd service
path in NixOS#58487 to fix gitaly-ruby's internal memory leak detection.

Now that the last ruby remnants have been removed in gitaly 16.0.0,
this should not be necessary anymore.
yayayayaka added a commit to yayayayaka/nixpkgs that referenced this pull request May 31, 2023
@yayayayaka
nixos/gitlab: Remove procps from gitaly service
6c17853 
From my understanding, procps was added to the gitlay systemd service
path in NixOS#58487 to fix gitaly-ruby's internal memory leak detection.

Now that the last ruby remnants have been removed in gitaly 16.0.0,
this should not be necessary anymore.
yu-re-ka pushed a commit that referenced this pull request May 31, 2023
@yayayayaka @yu-re-ka
nixos/gitlab: Remove procps from gitaly service
4321e48 
From my understanding, procps was added to the gitlay systemd service
path in #58487 to fix gitaly-ruby's internal memory leak detection.

Now that the last ruby remnants have been removed in gitaly 16.0.0,
this should not be necessary anymore.
github-actions bot pushed a commit that referenced this pull request May 31, 2023
@yayayayaka @github-actions
nixos/gitlab: Remove procps from gitaly service
5312eec 
From my understanding, procps was added to the gitlay systemd service
path in #58487 to fix gitaly-ruby's internal memory leak detection.

Now that the last ruby remnants have been removed in gitaly 16.0.0,
this should not be necessary anymore.

(cherry picked from commit 6c17853)
yu-re-ka pushed a commit that referenced this pull request Jun 4, 2023
@yayayayaka @yu-re-ka
nixos/gitlab: Remove procps from gitaly service
1a217e9 
From my understanding, procps was added to the gitlay systemd service
path in #58487 to fix gitaly-ruby's internal memory leak detection.

Now that the last ruby remnants have been removed in gitaly 16.0.0,
this should not be necessary anymore.

(cherry picked from commit 6c17853)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @infinisil @GrahamcOfBorg