Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inter,inter-ui: keep font name the same for attributes, split off #58520

Merged
merged 4 commits into from
Apr 5, 2019
Merged

inter,inter-ui: keep font name the same for attributes, split off #58520

merged 4 commits into from
Apr 5, 2019
+34 −4

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 29, 2019

Feedback please! This is one solution to the problem,
but since it's a small amount of work wanted an actual PR
and so if we like it it's easy to proceed.

Motivation for this change

#57605 (comment)

From upstream repository activity, it appears they're working
to be included in google fonts?
However I'm not sure it's worth "waiting" on that,
and it's nice to have the font you wnt directly sometimes
instead of the big bundle :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ivan
Copy link
Member

ivan commented Mar 29, 2019

Thanks! I tested this with pkgs.inter in my fonts.fonts and it seems to be working.

@dtzWill dtzWill force-pushed the update/inter-ui-vs-inter branch from 2f86106 to 0741927 Compare April 5, 2019 20:53
@dtzWill
Copy link
Member Author

dtzWill commented Apr 5, 2019

@GrahamcOfBorg build inter inter-ui

@dtzWill
Copy link
Member Author

dtzWill commented Apr 5, 2019

Merging before it becomes even more messy to do so :).

@dtzWill dtzWill merged commit 95ce16a into NixOS:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @ivan @GrahamcOfBorg