Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloud-utils: use qemu-utils instead of qemu #58471

Merged
merged 2 commits into from Oct 2, 2019
Merged

cloud-utils: use qemu-utils instead of qemu #58471

merged 2 commits into from Oct 2, 2019

Conversation

colemickens
Copy link
Member

Motivation for this change

Related issue: #58469

This greatly reduces the size of images that use cloud-init.
This seems safe to do per the upstream packaging:

Before/after:

595M     /nix/store/nmn798kahfqf47d4j6zfqwvy7m678hd0-digital-ocean-image
331M     /nix/store/kvq58qn9iqgpgr4v3dq9vk5zd05jz2ml-digital-ocean-image

I've booted this up, but haven't tested extensively. This should be tested with other images, but ought to be at least somewhat safe based on upstream packaging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens colemickens mentioned this pull request Apr 16, 2019
Closed
@eamsden eamsden mentioned this pull request Apr 16, 2019
Closed
10 tasks
@joachifm
Copy link
Contributor

@GrahamcOfBorg build cloud-utils

@colemickens colemickens mentioned this pull request Jun 26, 2019
Closed
10 tasks
@colemickens
Copy link
Member Author

see also: #50687

@joachifm
Copy link
Contributor

Any reason to not go ahead with this?

@colemickens
Copy link
Member Author

only reason I can see is if we want to merge #50687 and use it instead? but I haven't looked at it terribly closely. Since this mirrors how others are packaging these bits from qemu, it seems safe to merge to me. (Unless something else in a cloud image is implicitly relying on another binary in the qemu package, but I doubt it)

@wmertens
Copy link
Contributor

wmertens commented Oct 1, 2019

IMHO, this should be merged now and #50687 when it's ready - no reason to wait, no?

@joachifm joachifm merged commit 2c117ae into NixOS:master Oct 2, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 2, 2019
@joachifm @dtzWill
Merge pull request NixOS#58471 from colemickens/cu
8232a68 
cloud-utils: use `qemu-utils` instead of `qemu`
(cherry picked from commit 2c117ae)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@colemickens @joachifm @wmertens @GrahamcOfBorg