Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

steamcmd: Add needed binaries to PATH #58556

Merged
merged 1 commit into from Apr 6, 2019
Merged

steamcmd: Add needed binaries to PATH #58556

merged 1 commit into from Apr 6, 2019

Conversation

infinisil
Copy link
Member

Motivation for this change

Should fix #58479

@pmiddend Can you test whether this fixes your issue?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pmiddend
Copy link
Contributor

pmiddend commented Apr 1, 2019

Sorry @infinisil, just saw this PR. I can hopefully test it this week,

@pmiddend
Copy link
Contributor

pmiddend commented Apr 6, 2019

@infinisil This seems to work and can be merged now. :)

@infinisil infinisil merged commit c58c079 into NixOS:master Apr 6, 2019
@infinisil infinisil deleted the fix/steamcmd branch April 6, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using steamcmd in docker: mkdir not found
3 participants
@infinisil @pmiddend @GrahamcOfBorg