zfs_unstable: 0.8.0-rc3 -> 2019-03-29 #58553
Conversation
GrahamcOfBorg
added
10.rebuild-darwin: 0
|
Feel free to host the updated patch file yourself. I fail to see why you call it a "funny" domain. Also, afaik, TRIM has always been planned to be included into 0.8.0. Since it's zfs unstable I see no difference to go to latest git master. |
| isUnstable = true; | ||
|
|
||
| extraPatches = [ | ||
| # in case this gets out of date, just send Mic92 a pull request! |
There was a problem hiding this comment.
Please do that instead of deleting the comment.
There was a problem hiding this comment.
On a related note, would you be interested in upstreaming this a version of this patch? We have an opportunity to add NixOS to the ZFSoL CI / build farm, and I think not requiring patches would be a step in that direction.
There was a problem hiding this comment.
Please do that instead of deleting the comment.
This just got deleted by accident.
There was a problem hiding this comment.
@grahamc sounds good to me. Do you have some contacts in that direction?
|
I guess there's no interest. |
|
I was interested. The trim patch was merged to master, was it not? Could we not just point to master instead of hosting patches? @grahamc I do like being on a release candidate, but once 0.8 is released, zfsUnstable will have nowhere to point but master, right? It is a little odd to me that zfsUnstable currently points to a version that's over two months old; I think monthly updates would be considered normal for the unstable moniker. |
Motivation for this change
Adding ssd trim patch to zfs unstable: openzfs/zfs#8419
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)