Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle: 5.0 -> 5.3.1 #58528

Merged
merged 1 commit into from Apr 1, 2019
Merged

gradle: 5.0 -> 5.3.1 #58528

merged 1 commit into from Apr 1, 2019

Conversation

groodt
Copy link
Contributor

@groodt groodt commented Mar 29, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Mar 30, 2019

Do we have to keep 6 different gradle versions in nixpkgks? It should be possible to remove some old versions.

@groodt
Copy link
Contributor Author

groodt commented Mar 31, 2019

@xeji It's a good question and a good point. I've taken a quick look and this is what I've done:

  • I've bumped the "bugfix" versions of gradle_4_10 and gradle_3_5
  • Instead of introducing gradle_5_0, I've bumped gradle_latest all the way from 5.0 to 5.3.1
  • I've identified which nixpkgs are consuming the named gradle versions. Only gradle_2_14 and gradle_4_10 are unused by nixpkgs.
  • gradle_2_5 is consumed by packages called jd-gui and mxisd. If these are updated, then I feel that it might be appropriate to remove both gradle_2_5 and gradle_2_14.

Thoughts?

@xeji
Copy link
Contributor

xeji commented Mar 31, 2019

Sounds good, thanks for looking into it. Let's see if the bumped versions build:
@GrahamcOfBorg build gradle gradle_3_5 gradle_4_10

@groodt
Copy link
Contributor Author

groodt commented Apr 1, 2019

@xeji I think I've fixed the issue with the linux build of gradle. Please try Ofborg again when you get a chance.

@xeji
Copy link
Contributor

xeji commented Apr 1, 2019

@GrahamcOfBorg build gradle gradle_3_5 gradle_4_10

@xeji
Copy link
Contributor

xeji commented Apr 1, 2019

Thank you. nix-review shows no issues, so this is good to go.

@xeji xeji merged commit 92e5745 into NixOS:master Apr 1, 2019
@averelld averelld mentioned this pull request Dec 12, 2019
10 tasks
@ghost ghost mentioned this pull request Jan 10, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants