New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sahel-fonts: init at v1.0.0-alpha22 #58480
Conversation
{ stdenv, fetchFromGitHub }: | ||
|
||
stdenv.mkDerivation rec { | ||
name = "sahel-fonts"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name
attribute usually includes the version also. Use pname
here instead of name
.
|
||
src = fetchFromGitHub { | ||
owner = "rastikerdar"; | ||
repo = "sahel-font"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use pname
for the repo
.
|
||
meta = with stdenv.lib; { | ||
homepage = https://github.com/rastikerdar/sahel-font; | ||
description = "A Persian (farsi) Font - فونت (قلم) فارسی ساحل"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason not to stick with ASCII here.
cc @volth |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)