Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cudnn_cudatoolkit_10: 7.3.1 -> 7.4.2 #58484

Merged
merged 1 commit into from Apr 24, 2019
Merged

cudnn_cudatoolkit_10: 7.3.1 -> 7.4.2 #58484

merged 1 commit into from Apr 24, 2019

Conversation

sveitser
Copy link
Contributor

Motivation for this change

Update cudnn.

[nix-shell:/etc/nixos/nixpkgs]$ nix-review rev e29e315c5f92aa4d1544f231fc3750da52eb63f8
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0
$ git worktree add /home/lulu/.cache/nix-review/rev-e29e315c5f92aa4d1544f231fc3750da52eb63f8/nixpkgs 6670b4c37d4acfd4c2149fd60356d2d88c3ae4ef
Preparing worktree (detached HEAD 6670b4c37d4)
HEAD is now at 6670b4c37d4 Merge pull request #58419 from flokli/ldap-nslcd-startup
$ nix-env -f /home/lulu/.cache/nix-review/rev-e29e315c5f92aa4d1544f231fc3750da52eb63f8/nixpkgs -qaP --xml --out-path --show-trace
$ git merge --no-commit e29e315c5f92aa4d1544f231fc3750da52eb63f8
Updating 6670b4c37d4..e29e315c5f9
Fast-forward
 pkgs/development/libraries/science/math/cudnn/default.nix | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
$ nix-env -f /home/lulu/.cache/nix-review/rev-e29e315c5f92aa4d1544f231fc3750da52eb63f8/nixpkgs -qaP --xml --out-path --show-trace --meta
$ nix build --no-link --keep-going --max-jobs 32 --option build-use-sandbox true -f /home/lulu/.cache/nix-review/rev-e29e315c5f92aa4d1544f231fc3750da52eb63f8/build.nix
[6 built, 30 copied (251.6 MiB), 91.7 MiB DL]
3 package were build:
cudnn_cudatoolkit_10 python27Packages.tensorflowWithCuda python37Packages.tensorflowWithCuda
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sveitser
Copy link
Contributor Author

ping @mdaiter

@mdaiter
Copy link
Contributor

mdaiter commented Mar 31, 2019

I approve! Good work, and thanks for updating this @sveitser .
Just to ensure (because I don't have access to a Nix machine atm), you tested this, right? As long as it builds, it looks good to go.

@sveitser
Copy link
Contributor Author

Yes tested with tensorflow.

@mdaiter
Copy link
Contributor

mdaiter commented Mar 31, 2019

@sveitser merge it on in then!

@c0bw3b c0bw3b merged commit 6186a6f into NixOS:master Apr 24, 2019
@sveitser sveitser deleted the cudnn-v7.4.2 branch April 25, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sveitser @mdaiter @CMCDragonkai @infinisil @c0bw3b @GrahamcOfBorg