tests: change postgresql socket dir to /tmp #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In NixOS/nixpkgs#57677 default postgresql socket directory was changed to `/run/postgresql`, which doesn't exist (and can't be created) in Nix build environment. We'll use /tmp as socket dir explicitly then. Fixes build failure https://hydra.nixos.org/build/91221682 Cc @aszlig @edolstra
danbst
added a commit
to danbst/nixpkgs
that referenced
this pull request
Mar 30, 2019
Apply patch from NixOS/hydra#648
10 tasks
vdemeester
pushed a commit
to vdemeester/nixpkgs
that referenced
this pull request
Mar 30, 2019
Apply patch from NixOS/hydra#648
|
That patch is happily referenced from nixpkgs since http://github.com/NixOS/nixpkgs/commit/8e18f4e4143184f667de3ffb3fc958f2e34b6e29. It would be nice if could merge it to master and drop the patch from nixpkgs again, or is there anything blocking this from being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NixOS/nixpkgs#57677 default postgresql socket directory was changed
to
/run/postgresql, which doesn't exist (and can't be created) inNix build environment. We'll use /tmp as socket dir explicitly then.
Fixes build failure https://hydra.nixos.org/build/91221682
Cc @aszlig @edolstra