Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nextcloud: Cherry-pick nginx recommendations to 19.03 #58539

Merged
merged 1 commit into from Mar 29, 2019
Merged

nixos/nextcloud: Cherry-pick nginx recommendations to 19.03 #58539

merged 1 commit into from Mar 29, 2019

Conversation

herrwiese
Copy link
Contributor

Motivation for this change

This is already present in master, but didn't find its way into 19.03 release yet, which is kind of annoying as it keeps Nextcloud issueing a warning in Settings->Administration Overview, 'Your web server is not properly set up to resolve "/ocm-provider".'

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Mar 29, 2019

Thanks! Re-cherry-picked with -x to keep the reference to the originating commit.

@flokli flokli merged commit d11c540 into NixOS:release-19.03 Mar 29, 2019
@herrwiese herrwiese deleted the nc-backport-ocm-fix branch May 2, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@herrwiese @flokli @GrahamcOfBorg @bachp