Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bad5d145c28d
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 704d02053b6a
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Mar 29, 2019

  1. (ruby-modules/gem): (refactor) (#53525)

    * Changing leaveDotGit to git chacha on build
    
    * Removing debugging cruft
    
    * Simpler git handling
    
    * Can't clobber index after `add`
    
    * Update pkgs/development/ruby-modules/gem/default.nix
    
    Useful comments
    
    Co-Authored-By: nyarly <nyarly@users.noreply.github.com>
    
    * Update pkgs/development/ruby-modules/gem/default.nix
    
    Comments are useful
    
    Co-Authored-By: nyarly <nyarly@users.noreply.github.com>
    nyarly authored and zimbatm committed Mar 29, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    zimbatm Jonas Chevalier
    Copy the full SHA
    704d020 View commit details
Showing with 7 additions and 1 deletion.
  1. +7 −1 pkgs/development/ruby-modules/gem/default.nix
8 changes: 7 additions & 1 deletion pkgs/development/ruby-modules/gem/default.nix
Original file line number Diff line number Diff line change
@@ -63,7 +63,6 @@ let
else if type == "git" then
fetchgit {
inherit (attrs.source) url rev sha256 fetchSubmodules;
leaveDotGit = true;
}
else if type == "url" then
fetchurl attrs.source
@@ -95,6 +94,7 @@ stdenv.mkDerivation ((builtins.removeAttrs attrs ["source"]) // {

inherit src;


unpackPhase = attrs.unpackPhase or ''
runHook preUnpack
@@ -142,6 +142,12 @@ stdenv.mkDerivation ((builtins.removeAttrs attrs ["source"]) // {
gempkg=$(echo "$output" | grep -oP 'File: \K(.*)')
echo "gem package built: $gempkg"
elif [[ "$type" == "git" ]]; then
git init
# remove variations to improve the likelihood of a bit-reproducible output
rm -rf .git/logs/ .git/hooks/ .git/index .git/FETCH_HEAD .git/ORIG_HEAD .git/refs/remotes/origin/HEAD .git/config
# support `git ls-files`
git add .
fi
runHook postBuild