Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs-11_x: 11.11.0 -> 11.13.0 #58514

Merged
merged 1 commit into from Mar 30, 2019
Merged

nodejs-11_x: 11.11.0 -> 11.13.0 #58514

merged 1 commit into from Mar 30, 2019
+2 −2

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 29, 2019

Motivation for this change

Changelog:
https://nodejs.org/en/blog/release/v11.12.0/
https://nodejs.org/en/blog/release/v11.13.0/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Mar 30, 2019

Currently building locally on a x86_64-linux...

@Ma27 Ma27 merged commit d64080f into NixOS:master Mar 30, 2019
@Ma27
Copy link
Member

Ma27 commented Mar 30, 2019

@marsam thanks!

@marsam marsam deleted the nodejs_11-update branch March 30, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @Ma27 @GrahamcOfBorg