Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hplip: add missing dependency #58515

Merged
merged 1 commit into from Mar 30, 2019
Merged

hplip: add missing dependency #58515

merged 1 commit into from Mar 30, 2019

Conversation

hhm0
Copy link
Contributor

@hhm0 hhm0 commented Mar 29, 2019 •
edited

Graphical programs (e.g. hp-setup) error with:

error: No module named enum

This adds the enum module which fixes the error.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hhm0
hplip: add missing dependency
8308e41 
Graphical programs (e.g. hp-setup) error with:

error: No module named enum

This adds the enum module which fixes the error
@xeji
Copy link
Contributor

xeji commented Mar 30, 2019

@GrahamcOfBorg build hplip

@xeji xeji merged commit edb3231 into NixOS:master Mar 30, 2019
@cx405 cx405 mentioned this pull request Jul 17, 2019
Closed
@cx405
Copy link

cx405 commented Jul 17, 2019

@hhm0 Still an issue on current 19.03:

[userp@nix01:~]$ hp-toolbox 

HP Linux Imaging and Printing System (ver. 3.19.1)
HP Device Manager ver. 15.0

Copyright (c) 2001-15 HP Development Company, LP
This software comes with ABSOLUTELY NO WARRANTY.
This is free software, and you are welcome to distribute it
under certain conditions. See COPYING file for more details.

error: No module named enum

[userp@nix01:~]$ nixos-version
19.03.173144.973a2705351 (Koi)

@matthewbauer
Copy link
Member

Cherry picked in 77295b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hhm0 @xeji @cx405 @matthewbauer @GrahamcOfBorg