Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libfido2: init at 1.1.0 (and libcor dep) #58543

Merged
merged 4 commits into from May 21, 2019
Merged

libfido2: init at 1.1.0 (and libcor dep) #58543

merged 4 commits into from May 21, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 29, 2019

Motivation for this change

https://developers.yubico.com/FIDO2/

Seems good to have-- although don't know of any
projects using it yet, the recent 1.0.0 release
might see this change.
For example it looks like pam-u2f is poised
to move to this, see upstream PR 98.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Apr 13, 2019

Might it be worth using the contents of the regress/ directory as some minimal tests for libfido2?

Anyway - builds fine for me non-nixos linux x86_64.

@dtzWill dtzWill changed the title libfido2: init at 1.0.0 (and libcor dep) libfido2: init at 1.1.0 (and libcor dep) May 9, 2019
@dtzWill dtzWill merged commit 3c3085b into NixOS:master May 21, 2019
@dtzWill dtzWill deleted the feature/libfido2 branch May 21, 2019 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @risicle @GrahamcOfBorg