Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lugaru: init at 1.2 #58548

Merged
merged 1 commit into from Mar 30, 2019
Merged

lugaru: init at 1.2 #58548

merged 1 commit into from Mar 30, 2019

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Mar 29, 2019 •
edited

Motivation for this change

OSS Lugaru !

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

flokli
flokli requested changes Mar 30, 2019
View reviewed changes
pkgs/games/lugaru/default.nix Outdated
version = "1.2";

src = fetchurl {
url = "https://gitlab.com/osslugaru/lugaru/-/archive/${version}/lugaru-${version}.tar.bz2";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a [tab] here that shouldn't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@flokli
Copy link
Contributor

flokli commented Mar 30, 2019

@GrahamcOfBorg build lugaru

@flokli flokli merged commit 46b63d7 into NixOS:master Mar 30, 2019
@bignaux bignaux deleted the lugaru branch December 17, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bignaux @flokli @GrahamcOfBorg