Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.vscodevim.vim: init at 1.2.0 #58500

Merged
merged 1 commit into from
Mar 28, 2019
Merged

vscode-extensions.vscodevim.vim: init at 1.2.0 #58500

merged 1 commit into from
Mar 28, 2019
+12 −0

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented Mar 28, 2019

Motivation for this change

Wanted to use some vim keybindings on vscode.

I have tested it locally and seems to be working for simple things.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 28, 2019
@veprbl
Copy link
Member

veprbl commented Mar 28, 2019

cc @eadwu as vscode maintainer

@eadwu
Copy link
Member

eadwu commented Mar 28, 2019

Looks fine and verified hash.

@veprbl veprbl merged commit 3517083 into NixOS:master Mar 28, 2019
@veprbl
Copy link
Member

veprbl commented Mar 28, 2019

@jokogr @eadwu Thank you!

@jokogr jokogr deleted the n/vscode-extensions.vscodevim.vim branch March 28, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jokogr @veprbl @eadwu @GrahamcOfBorg