spotifyd: fix build #65637
Closed
spotifyd: fix build #65637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
reviewed
Jul 31, 2019
| @@ -18609,7 +18609,7 @@ in | |||
|
|
|||
| spotifyd = callPackage ../applications/audio/spotifyd { | |||
| withALSA = stdenv.isLinux; | |||
| withPulseAudio = config.pulseaudio or true; | |||
There was a problem hiding this comment.
This seems wrong to me. We should enable pulseaudio by default. Or is there a reason it's disabled?
There was a problem hiding this comment.
sorry for the late response. I think we should not enable pulseaudio on darwin, so config.pulseaudio or stdenv.isLinux may be an alternative; but since spotifyd is broken on darwin, and I can't manage to fix it, it does not matter right now.
|
addressed by #66233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See: https://hydra.nixos.org/build/97195438
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @