ranger: Add myself to CODEOWNERS for ranger #65604
Conversation
I'm one of the maintainers of the ranger package but I'm not a NixOS maintainer so I don't get notified when PRs affect the package. This makes it hard to "maintain" anything. I always figured this would be a misuse of CODEOWNERS but multiple NixOS maintainers have told me, "Well, that's what CODEOWNERS is for." So this is my way of committing to maintaining the nixpkgs expression for ranger.
|
We can add you there. However I wonder why you don't get notified by our bot: #65602 (comment) |
|
This will not work. Unfortunately, accounts who are not members of NixOS organization can not be assigned as reviewers so ofborg can not request a review from you. GitHub's CODEOWNERS are not effective for non-members for a similar reason, I think. The solution for this would be to make ofborg ping maintainers or to add everyone to the organization. cc @grahamc |
|
Aha, thanks anyway. @Mic92, that's the first thing everyone says, "ofBorg already does this." But I think it too only mentions NixOS maintainers. |
|
I'm one of the maintainers of the ranger package but I'm not a NixOS
maintainer so I don't get notified when PRs affect the package. This
I have a feeling you would also be a good test user for RFC39… no idea
about the timeline there, though…
|
|
Sure, this was a workaround until that gets implemented. Though I'm not happy it requires 2FA for github. |
|
I just manually created the Nixpkgs Maintainers team on GitHub with read-only access to Nixpkgs, and added @toonn to it. I've also started a document about 2FA to help describe ways to implement it, and why it is important. |
|
BTW once @toonn is part of this team, no need to add them to CODEOWNERS since ofborg will tag them on relevant PRs automatically. |
I'm one of the maintainers of the ranger package but I'm not a NixOS
maintainer so I don't get notified when PRs affect the package. This
makes it hard to "maintain" anything. I always figured this would be a
misuse of CODEOWNERS but multiple NixOS maintainers have told me, "Well,
that's what CODEOWNERS is for." So this is my way of committing to
maintaining the nixpkgs expression for ranger.