Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib3mf: add missing uuid dependency on Darwin #65555

Merged
merged 1 commit into from Jul 29, 2019
Merged

lib3mf: add missing uuid dependency on Darwin #65555

merged 1 commit into from Jul 29, 2019

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Fix darwin build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 29, 2019
@ofborg ofborg bot requested a review from gebner July 29, 2019 13:05
@veprbl
Copy link
Member

veprbl commented Jul 29, 2019

@GrahamcOfBorg build lib3mf

@veprbl veprbl merged commit 72e547e into NixOS:master Jul 29, 2019
@thefloweringash thefloweringash deleted the lib3mf-darwin branch July 29, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thefloweringash @veprbl