Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpxsee: 7.9 -> 7.11 #65568

Merged
merged 1 commit into from Jul 31, 2019
Merged

gpxsee: 7.9 -> 7.11 #65568

merged 1 commit into from Jul 31, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jul 29, 2019

Motivation for this change

Changelog:

  • Update to version 7.11
    • Improved IMG maps loading performance and memory footprint.
    • Improved road shields layout on IMG maps.
  • Update to version 7.10
    • Various IMG maps fixes and improvements.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Jul 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When i try to run this, i get:

[nix-shell:~/.cache/nix-review/pr-65568]$ ./results/gpxsee/bin/gpxsee
qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Perhaps use wrapQtAppsHook?

@sikmir
Copy link
Member Author

sikmir commented Jul 29, 2019

Changed makeWrapper to wrapQtAppsHook.

jonringer
jonringer approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
binary works

worldofpeace
worldofpeace approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍

@worldofpeace worldofpeace merged commit 05df9ce into NixOS:master Jul 31, 2019
@sikmir sikmir deleted the update-gpxsee branch July 31, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @jonringer @worldofpeace