Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: 0.14.2 -> 0.14.3 #65546

Merged
merged 3 commits into from Jul 29, 2019
Merged

kitty: 0.14.2 -> 0.14.3 #65546

merged 3 commits into from Jul 29, 2019

Conversation

rvolosatovs
Copy link
Member

Motivation for this change

Upstream update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rvolosatovs
Copy link
Member Author

@GrahamcOfBorg build kitty

@veprbl
Copy link
Member

veprbl commented Jul 29, 2019

@GrahamcOfBorg build kitty

globin
globin requested changes Jul 29, 2019
View reviewed changes
Copy link
Member

@globin globin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The darwin patches no longer apply.

@rvolosatovs
Copy link
Member Author

Sorry, I'm unable to test Darwin builds at this time - @globin can you either specify what is to be done to fix those or contribute?

@veprbl veprbl self-assigned this Jul 29, 2019
@veprbl
Copy link
Member

veprbl commented Jul 29, 2019

@GrahamcOfBorg build kitty

@veprbl veprbl removed their assignment Jul 29, 2019
@veprbl
Copy link
Member

veprbl commented Jul 29, 2019

@GrahamcOfBorg build kitty

@globin globin merged commit 31358a8 into NixOS:master Jul 29, 2019
@rvolosatovs rvolosatovs deleted the update/kitty branch July 29, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin globin requested changes

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rvolosatovs @veprbl @globin