Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parity: 2.4.9 -> 2.5.5, parity-beta: 2.5.4 -> 2.6.0 #65628

Merged
merged 3 commits into from Jul 31, 2019
Merged

parity: 2.4.9 -> 2.5.5, parity-beta: 2.5.4 -> 2.6.0 #65628

merged 3 commits into from Jul 31, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jul 31, 2019 •
edited

Motivation for this change

Update parity and parity-beta to the latest releases.

Note: This PR depends on #65385. We need the commit 626ccd7 to build parity-beta.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @akru

@akru
Copy link
Contributor

akru commented Jul 31, 2019

@xrelkd Looks good, thank you for your work!

@xrelkd
Copy link
Contributor Author

xrelkd commented Jul 31, 2019

@akru You're welcome!
Hi, @worldofpeace @marsam could you review this PR? Thank you very much!

@GrahamcOfBorg build parity parity-beta
(build it again on x86_64-linux)

@marsam marsam merged commit 28effc0 into NixOS:staging Jul 31, 2019
@marsam
Copy link
Contributor

marsam commented Jul 31, 2019

Thanks!

@xrelkd xrelkd deleted the update/parity branch July 31, 2019 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @akru @marsam