Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde_applications: 19.04.1 -> 19.08.0; kdeFrameworks: 5.58 -> 5.61; plasma-5: 5.15.5 -> 5.16.4 #65561

Merged
merged 26 commits into from Aug 16, 2019
Merged

kde_applications: 19.04.1 -> 19.08.0; kdeFrameworks: 5.58 -> 5.61; plasma-5: 5.15.5 -> 5.16.4 #65561

merged 26 commits into from Aug 16, 2019

Conversation

nyanloutre
Copy link
Member

@nyanloutre nyanloutre commented Jul 29, 2019 •
edited

Motivation for this change

the plasma5 test is passing, I did not test to boot my system on it yet

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nyanloutre nyanloutre requested a review from ttuegel as a code owner July 29, 2019 16:44
@bkchr
Copy link
Contributor

bkchr commented Jul 29, 2019

Last time I tried it with my changes (similar to yours), I could not get sddm to start... Would be nice you try booting your system :)

@nyanloutre
Copy link
Member Author

I can boot but SDDM is complaining and doesn't load the default theme correctly

@nyanloutre nyanloutre changed the title kde_applications: 19.04.1 -> 19.04.3; kdeFrameworks: 5.58 -> 5.60; plasma-5: 5.15.5 -> 5.16.3 kde_applications: 19.04.1 -> 19.04.3; kdeFrameworks: 5.58 -> 5.60; plasma-5: 5.15.5 -> 5.16.4 Jul 31, 2019
@nyanloutre
Copy link
Member Author

IMG_20190731_184435

@nyanloutre
Copy link
Member Author

What I can see is that Clock.qml is trying to include "QtQuick.Controls 2.5" but according to the doc, this version never existed (2.12 came after 2.4)

@ofborg ofborg bot requested a review from abbradar July 31, 2019 18:27
@nyanloutre
Copy link
Member Author

SDDM is working now.

I have another problem with akonadi which is not started automatically with kmail, but it was already happening before this update.

@Vskilet
Copy link
Contributor

Vskilet commented Aug 1, 2019 •
edited

I have another problem with akonadi which is not started automatically with kmail, but it was already happening before this update.

Do you have an error with MySql on start of akonadi and after it crash ?

@nyanloutre
Copy link
Member Author

No I can start it with akonadictl start

@nyanloutre
Copy link
Member Author

@bkchr Did you had time to test it ?

I am using it for a few days now and it seems fine

@bkchr
Copy link
Contributor

bkchr commented Aug 5, 2019

Yeah, using it since last week or so.

The bluetooth applet is still broken:

Error loading QML file: file:///nix/store/wdq1nqm5x8bw35hnn4h2ajn3cfa334c0-bluedevil-5.16.4/share/plasma/plasmoids/org.kde.plasma.bluetooth/contents/ui/BluetoothApplet.qml:24:1: module "org.kde.bluezqt" is not installed

It was already broken before, but we should fix it with this update.

Then I have the feeling that the new notification system maybe misses something. The notification are glitching into the view and disorting windows below it some time, but I'm not sure if that is KDE's fault. 🤷‍♀️

@nyanloutre
Copy link
Member Author

I don't see anything strange with the notification center

@nyanloutre
Copy link
Member Author

I also noticed a bug that happened before this update (and that is not still not fixed) the loading screen after login will stay for long time (like 10 seconds instead of 1), even if everything seems loaded (no disk activity)

@ttuegel
Copy link
Member

ttuegel commented Aug 7, 2019

@bkchr Your BlueZ issue should be fixed in #66226.

@bkchr
Copy link
Contributor

bkchr commented Aug 7, 2019

@bkchr Your BlueZ issue should be fixed in #66226.

Perfect :) Ty

@nyanloutre
Copy link
Member Author

nyanloutre commented Aug 8, 2019 •
edited

CVE on KDE framework < 5.61

https://nvd.nist.gov/vuln/detail/CVE-2019-14744

PR updated

@nyanloutre nyanloutre changed the title kde_applications: 19.04.1 -> 19.04.3; kdeFrameworks: 5.58 -> 5.60; plasma-5: 5.15.5 -> 5.16.4 kde_applications: 19.04.1 -> 19.04.3; kdeFrameworks: 5.58 -> 5.61; plasma-5: 5.15.5 -> 5.16.4 Aug 12, 2019
@nyanloutre
Copy link
Member Author

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from FRidh August 12, 2019 09:51
@mmahut
Copy link
Member

mmahut commented Aug 13, 2019

We might want to backport CVE-2019-14744 to the release-19.03.

@nyanloutre
Copy link
Member Author

After my last commits my system seems functional

@nyanloutre
Copy link
Member Author

KDE Applications 19.08 is out: https://kde.org/announcements/announce-applications-19.08.0.php

ttuegel
ttuegel reviewed Aug 15, 2019
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyanloutre This looks good, but could you rebase it into staging due to the size of the rebuild?

@nyanloutre nyanloutre changed the base branch from master to staging August 16, 2019 07:59
@nyanloutre
Copy link
Member Author

About 3400620 I am not quite sure how it should work. The similar cmake option NIXPKGS_POSTGRES_PG_CTL was already set to an empty string, so I did the same for the new NIXPKGS_POSTGRES_PG_UPGRADE.

Does it mean this will compile but not work ?

@ttuegel
Copy link
Member

ttuegel commented Aug 16, 2019

Those options need to be overridden for Akonadi to use Postgres instead of MySQL, which isn't a configuration we support. So, that sounds fine to me.

@ttuegel ttuegel merged commit ed3cb39 into NixOS:staging Aug 16, 2019
@nyanloutre nyanloutre deleted the plasma_update_5_16_3 branch August 18, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@abbradar abbradar Awaiting requested review from abbradar

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
1.severity: security 6.topic: qt/kde 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nyanloutre @bkchr @Vskilet @ttuegel @mmahut