Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.flocq: 3.1.0 -> 3.2.0 #65544

Merged
merged 2 commits into from Aug 5, 2019
Merged

coqPackages.flocq: 3.1.0 -> 3.2.0 #65544

merged 2 commits into from Aug 5, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jul 29, 2019

Motivation for this change

Ensures compatibility with Coq 8.10

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Jul 29, 2019

@GrahamcOfBorg build coqPackages.flocq

Zimmi48
Zimmi48 reviewed Jul 31, 2019
View reviewed changes
Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That may not be the official way of getting the release, but given that Flocq is now developed on Inria's GitLab, I would use the source URL

"https://gitlab.inria.fr/flocq/flocq/-/archive/flocq-${version}.tar.gz"

which would avoid having a uid parameter to update.

@vbgl vbgl changed the title coqPackages.flocq: 3.2.0 -> 3.2.1 coqPackages.flocq: 3.1.0 -> 3.2.0 Jul 31, 2019
@vbgl
Copy link
Contributor Author

vbgl commented Jul 31, 2019

I’ve update the source attribute do download from the git repository. Unfortunately, fetchFromGitLab does not seem to work (I don’t know what versions of the API are available on the Inria instance).

@vbgl vbgl merged commit 5b0fdad into NixOS:master Aug 5, 2019
@vbgl vbgl deleted the coq-flocq-3.2.1 branch August 5, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zimmi48 Zimmi48 Zimmi48 left review comments

Assignees
No one assigned
Labels
6.topic: coq 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @Zimmi48