Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/hardened: make pti=on overridable #65585

Merged
merged 1 commit into from Jul 30, 2019
Merged

nixos/hardened: make pti=on overridable #65585

merged 1 commit into from Jul 30, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Jul 30, 2019

Motivation for this change

Introduces a new security.forcePageTableIsolation option (default false
on !hardened, true on hardened) that forces pti=on.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
nixos/hardened: make pti=on overridable
67b7e70 
Introduces a new security.forcePageTableIsolation option (default false
on !hardened, true on hardened) that forces pti=on.
@delroth delroth requested a review from joachifm as a code owner July 30, 2019 00:32
ivan
ivan approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied and tested this. LGTM

@joachifm joachifm merged commit a7d71da into NixOS:master Jul 30, 2019
@joachifm
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan approved these changes

@joachifm joachifm Awaiting requested review from joachifm joachifm is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @joachifm @ivan