Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pwgen-secure: init at 0.9.1 #65618

Merged
merged 1 commit into from Jul 31, 2019
Merged

pwgen-secure: init at 0.9.1 #65618

merged 1 commit into from Jul 31, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

I'm upstreaming local changes in preparation for 19.09.

Cc: star reviewer @worldofpeace

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Jul 31, 2019
View reviewed changes
pkgs/tools/security/pwgen_secure/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/pwgen_secure/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@peterhoeg
Copy link
Member Author

Changing the _ to - - no problem.

As for the python version, indeed, it needs 3.6 and above. Good catch!

@peterhoeg peterhoeg changed the title pwgen_secure: init at 0.9.1 pwgen-secure: init at 0.9.1 Jul 31, 2019
worldofpeace
worldofpeace suggested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add doCheck = false because there's no checks.

Tested that it works, so with that we're good to merge.

@peterhoeg peterhoeg merged commit f46b8a9 into NixOS:master Jul 31, 2019
@peterhoeg
Copy link
Member Author

Cool, thanks for your help.

@peterhoeg peterhoeg deleted the p/spwgen branch July 31, 2019 07:18
@peterhoeg peterhoeg restored the p/spwgen branch July 31, 2019 10:11
@peterhoeg peterhoeg deleted the p/spwgen branch August 5, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @worldofpeace