Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: 75.0.3770.90 -> 76.0.3809.87 #65633

Merged
merged 2 commits into from Aug 2, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Jul 31, 2019

Motivation for this change

https://chromereleases.googleblog.com/2019/07/stable-channel-update-for-desktop_30.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested chromium and YouTube, audio, WebGL appear to work fine on two machines

Tested chromiumDev and YouTube, audio, WebGL appear to work fine

chromiumBeta points to the same version as chromium, I did not test other than confirming the build starts.

Notify maintainers

cc @bendlas @andir

@primeos
Copy link
Member

primeos commented Jul 31, 2019

@ivan Btw I think you've somehow based this change on the wrong commit (too old) as the old version is 75.0.3770.80 while it should be 75.0.3770.90 (in case you haven't already noticed it) ;)

Edit: Nvm, you've just fixed it :)

@primeos primeos changed the title chromium: 75.0.3770.80 -> 76.0.3809.87 chromium: 75.0.3770.90 -> 76.0.3809.87 Jul 31, 2019
ivan added 2 commits July 31, 2019 11:30
Fixes:

ERROR Unresolved dependencies.
//third_party/perfetto/gn:zlib(//build/toolchain/linux:clang_x64)
  needs //third_party/zlib:zlib_config(//build/toolchain/linux:clang_x64)

builder for '/nix/store/iqr4vn2by1yxa7f92jiymvgfsn9mdvwq-chromium-unwrapped-77.0.3860.5.drv' failed with exit code 1
Copy link
Member

@angristan angristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using nix-review ✔️

@ivan
Copy link
Member Author

ivan commented Aug 2, 2019

I've used updated chromium for another two days and haven't found any problems.

@grahamc grahamc merged commit 43ac110 into NixOS:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants