buildOcaml: remove camlp4 dependency #65632
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This removes the dependency on camlp4 for most packages that are built with
buildOcaml
, making it easier to test these packages on recent versions of OCaml where camlp4 might not yet be available.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Running
nix-shell -p nix-review --run "nix-review wip"
allowed to test this change against the following list of packages and their dependencies (but some OCaml packages have still probably been missed in the process):alt-ergo framac fstar google-drive-ocamlfuse jackline libbap ocamlPackages.asn1-combinators ocamlPackages.async_ssl ocamlPackages.bap ocamlPackages.cryptokit ocamlPackages.ctypes ocamlPackages.eliom ocamlPackages.email_message ocamlPackages.erm_xmpp ocamlPackages.gapi_ocaml ocamlPackages.git ocamlPackages.git-http ocamlPackages.git-unix ocamlPackages.js_build_tools ocamlPackages.llvm ocamlPackages.merlin_extend ocamlPackages.nocrypto ocamlPackages.ocsigen-start ocamlPackages.ocsigen-toolkit ocamlPackages.ocsigen_server ocamlPackages.otr ocamlPackages.reason ocamlPackages.tls ocamlPackages.tsdl ocamlPackages.x509 ocamlPackages.zarith opa python27Packages.bap python37Packages.bap trv why3
Notify maintainers
cc @vbgl