Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multimc: 0.6.4 -> 0.6.6 #65550

Merged
merged 1 commit into from Jul 29, 2019
Merged

multimc: 0.6.4 -> 0.6.6 #65550

merged 1 commit into from Jul 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 29, 2019

Use -DMultiMC_LAYOUT=lin-system to install shared object files to
$out/lib and the jars required at runtime to $out/share/multimc.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

multimc: 0.6.4 -> 0.6.6
c79aa36 
Use -DMultiMC_LAYOUT=lin-system to install shared object files to
$out/lib and the jars required at runtime to $out/share/multimc.
@worldofpeace
Copy link
Contributor

Directory structure changes should fix #56684 ?

@ofborg ofborg bot requested a review from cleverca22 July 29, 2019 10:45
@ghost
Copy link
Author

ghost commented Jul 29, 2019 •
edited by ghost

Yes. This is how the directory structure looks with this PR applied:

result/
├── bin
│   └── multimc
├── lib
│   ├── libMultiMC_gui.so
│   ├── libMultiMC_iconfix.so
│   ├── libMultiMC_logic.so
│   ├── libMultiMC_nbt++.so
│   ├── libMultiMC_quazip.so
│   ├── libMultiMC_rainbow.so
│   └── libMultiMC_unpack200.so
└── share
    ├── applications
    │   └── multimc.desktop
    ├── multimc
    │   └── jars
    │       ├── JavaCheck.jar
    │       └── NewLaunch.jar
    └── pixmaps
        └── multimc.svg

7 directories, 12 files

@worldofpeace
Copy link
Contributor

changelog: https://github.com/MultiMC/MultiMC5/blob/5110b58def7e3e3118e6624959d6e5d561002c74/changelog.md

@globin globin merged commit 2b44d15 into NixOS:master Jul 29, 2019
@globin globin mentioned this pull request Jul 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleverca22 cleverca22 Awaiting requested review from cleverca22

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worldofpeace @globin