Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow GnuPG1 to build on all platforms. #65617

Merged
merged 1 commit into from Aug 1, 2019
Merged

Allow GnuPG1 to build on all platforms. #65617

merged 1 commit into from Aug 1, 2019

Conversation

gcv
Copy link
Contributor

@gcv gcv commented Jul 31, 2019

Motivation for this change

The GnuPG1 package is excluded from being built on Darwin, but works just fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @r-ryantm

@mmahut
Copy link
Member

mmahut commented Jul 31, 2019

Please amend the commit message to something like gnupg: Allow GnuPG1 to build on all platforms.

@mmahut
Copy link
Member

mmahut commented Jul 31, 2019

@GrahamcOfBorg build gnupg

@gcv
Copy link
Contributor Author

gcv commented Jul 31, 2019

@mmahut: Done and force-pushed.

@adisbladis adisbladis merged commit 1a46901 into NixOS:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gcv @mmahut @adisbladis @Janik-Haag