Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluentd: 1.4.2 -> 1.6.2 #65560

Merged
merged 2 commits into from Jul 29, 2019
Merged

fluentd: 1.4.2 -> 1.6.2 #65560

merged 2 commits into from Jul 29, 2019

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Package update and simple test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Jul 29, 2019

@GrahamcOfBorg test fluentd

@veprbl
Copy link
Member

veprbl commented Jul 29, 2019

@GrahamcOfBorg build fluentd

mmahut
mmahut approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries
  • run the tests

@veprbl veprbl merged commit dbb5044 into NixOS:master Jul 29, 2019
@thefloweringash thefloweringash deleted the fluentd-update branch August 26, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thefloweringash @globin @veprbl @mmahut