Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad: 0.9.3 -> 0.9.4 #65629

Merged
merged 1 commit into from Jul 31, 2019
Merged

nomad: 0.9.3 -> 0.9.4 #65629

merged 1 commit into from Jul 31, 2019

Conversation

endocrimes
Copy link
Member

@endocrimes endocrimes commented Jul 31, 2019 •
edited

Motivation for this change

Nomad 0.9.4 was released yesterday.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rushmorem @pradeepchhetri

@endocrimes endocrimes changed the title nomad: Upgrade to 0.9.4 nomad: 0.9.3 -> 0.9.4 Jul 31, 2019
@srhb
Copy link
Contributor

srhb commented Jul 31, 2019

Looks good with sandbox on too.

@srhb srhb merged commit 7a7cf6f into NixOS:master Jul 31, 2019
@endocrimes endocrimes deleted the r-nomad-0.9.4 branch July 31, 2019 15:52
@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/53

@worldofpeace worldofpeace mentioned this pull request Aug 19, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@endocrimes @srhb @nixos-discourse @Janik-Haag