Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustracer: 2.0.14 -> 2.1.22 #65596

Merged
merged 2 commits into from Jul 30, 2019
Merged

rustracer: 2.0.14 -> 2.1.22 #65596

merged 2 commits into from Jul 30, 2019

Conversation

arcnmx
Copy link
Member

@arcnmx arcnmx commented Jul 30, 2019 •
edited

Motivation for this change

Update racer since the package is currently broken, and throw in a racerd update while we're at it. A number of tests are failing that I haven't looked into too closely, I think they need a cargo cache or network? Not quite sure...

Anyone able to run a build for darwin?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arcnmx arcnmx mentioned this pull request Jul 30, 2019
Closed
@ofborg ofborg bot requested review from jagajaga and globin July 30, 2019 05:26
@Mic92
Copy link
Member

Mic92 commented Jul 30, 2019

@GrahamcOfBorg build rustracer

@Mic92 Mic92 merged commit 445c997 into NixOS:master Jul 30, 2019
@Mic92
Copy link
Member

Mic92 commented Jul 30, 2019 •
edited

It seems like it is missing the Security framework on macOS now. This can be fixed in a follow up pull request. I merge this now to fix at least the Linux version for the time being.

@Mic92 Mic92 mentioned this pull request Jul 30, 2019
Closed
10 tasks
@Mic92
Copy link
Member

Mic92 commented Jul 30, 2019

followup: #65598

@arcnmx arcnmx deleted the pr-racer-update branch July 30, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagajaga jagajaga Awaiting requested review from jagajaga

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arcnmx @Mic92