New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.datatable: fix darwin build #65613
Conversation
@GrahamcOfBorg build python3Packages.datatable |
keep forgetting that ofBorg doesn't build darwin anymore, darn :( |
I'm still getting the same error. |
I believe that's because you need to be a trusted user to trigger darwin builds. |
@worldofpeace I don't trust me. :) |
This is building for me now on Darwin. I have not squashed the commits yet, it's probably best to squash and merge when ready. @GrahamcOfBorg build python3Packages.datatable |
pkgs/development/python-modules/datatable/hardcode-library-paths.patch
Outdated
Show resolved
Hide resolved
@worldofpeace PTAL @GrahamcOfBorg build python3Packages.datatable |
We may be able to edit/remove the buildInputs addition. Nix should be able to detect that there are store paths. Are you able to run this package with a normal workload? |
I have not tried doing that. It was failing for me due to the lack of |
Removing openmp breaks the build, but I may the add the others since I'm assuming they will be needed at runtime anyway. Other than that, I don't have a good way to test this package actually works :( |
The tests pass. I've also checked the linked dynamic libraries and they look good. |
Motivation for this change
Attempt to resolve #65611
Need to be at home before I can verify on my own mac.
Verified it doesn't affect linux derivation.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @kalbasit