Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.datatable: fix darwin build #65613

Merged
merged 5 commits into from Aug 1, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Attempt to resolve #65611

Need to be at home before I can verify on my own mac.

Verified it doesn't affect linux derivation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @kalbasit

@jonringer jonringer requested a review from FRidh as a code owner July 30, 2019 20:34
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 30, 2019
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.datatable

@jonringer
Copy link
Contributor Author

keep forgetting that ofBorg doesn't build darwin anymore, darn :(

@kalbasit
Copy link
Member

I'm still getting the same error.

@worldofpeace
Copy link
Contributor

keep forgetting that ofBorg doesn't build darwin anymore, darn :(

I believe that's because you need to be a trusted user to trigger darwin builds.
It may be a good idea to submit that at the ofborg repo if you plan on regularly
contributing to the darwin infrastructure in nixpkgs.

@jonringer
Copy link
Contributor Author

@worldofpeace I don't trust me. :)

@kalbasit
Copy link
Member

kalbasit commented Jul 31, 2019

This is building for me now on Darwin. I have not squashed the commits yet, it's probably best to squash and merge when ready.

@GrahamcOfBorg build python3Packages.datatable

@kalbasit
Copy link
Member

@worldofpeace PTAL

@GrahamcOfBorg build python3Packages.datatable

@jonringer
Copy link
Contributor Author

We may be able to edit/remove the buildInputs addition. Nix should be able to detect that there are store paths. Are you able to run this package with a normal workload?

@kalbasit
Copy link
Member

We may be able to edit/remove the buildInputs addition. Nix should be able to detect that there are store paths. Are you able to run this package with a normal workload?

I have not tried doing that. It was failing for me due to the lack of shutil and I noticed that it was attempting to copy native binaries to the build directory which useless anyway.

@jonringer
Copy link
Contributor Author

Removing openmp breaks the build, but I may the add the others since I'm assuming they will be needed at runtime anyway.

Other than that, I don't have a good way to test this package actually works :(

@kalbasit
Copy link
Member

kalbasit commented Aug 1, 2019

Removing openmp breaks the build, but I may the add the others since I'm assuming they will be needed at runtime anyway.

Other than that, I don't have a good way to test this package actually works :(

The tests pass. I've also checked the linked dynamic libraries and they look good.

@kalbasit kalbasit merged commit b1f0e2a into NixOS:master Aug 1, 2019
@jonringer jonringer deleted the fix-datatable-darwin branch August 8, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pythonPackages.datatable is failing to build on Darwin
3 participants