Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pam: add redHatModules option #65636

Closed
wants to merge 1 commit into from
Closed

pam: add redHatModules option #65636

wants to merge 1 commit into from

Conversation

hyperfekt
Copy link
Contributor

Motivation for this change

There are some PAM modules that are used by Red-Hat-associated distros such as Fedora, CentOS and RHEL, which could be useful for others too but have not been upstreamed.
Concretely, those are pam_faillock, pam_console, pam_chroot and pam_postgresok.
pam_faillock has the advantage of working with screensavers, as opposed to the included by default pam_tally and pam_tally2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hyperfekt hyperfekt force-pushed the pam_redhat branch 3 times, most recently from cecac7d to 4e11276 Compare July 31, 2019 11:19
@hyperfekt hyperfekt changed the base branch from master to staging July 31, 2019 11:50
FRidh
FRidh reviewed Aug 3, 2019
View reviewed changes
pkgs/os-specific/linux/pam/default.nix
@@ -1,65 +1,90 @@
{ stdenv, buildPackages, fetchurl, fetchpatch, flex, cracklib, db4 }:
{ stdenv, buildPackages, fetchurl, fetchpatch, flex, cracklib, db4, redHatModules ? false, autoreconfHook ? null, yacc ? null, pkgconfig ? null, libxslt ? null, libxml2 ? null, docbook_xsl ? null, docbook_xml_dtd_44 ? null, docbook_xml_dtd_43 ? null, w3m ? null, docbook_xml_dtd_412 ? null }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, but please order attributes vertically instead of horizontally. It reduces the diff when changes are needed

@FRidh FRidh added this to Needs review in Staging Dec 31, 2019
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 9, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 9, 2021
Artturin
Artturin reviewed Aug 30, 2023
View reviewed changes
pkgs/os-specific/linux/pam/default.nix
stdenv.mkDerivation rec {
name = "linux-pam-${version}";
version = "1.3.1";
assert redHatModules -> stdenv.lib.all (x: x != null) [ autoreconfHook yacc pkgconfig libxslt libxml2 docbook_xsl docbook_xml_dtd_44 docbook_xml_dtd_43 w3m ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the null's are unnecessary

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 30, 2023
@Artturin
Copy link
Member

Please open a new PR if this is still wanted.

@Artturin Artturin closed this Aug 30, 2023
Staging automation moved this from Needs review to Done Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@Artturin Artturin Artturin left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hyperfekt @Artturin @FRidh @ryantm