Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aerc: 0.1.4 -> 0.2.1; add ncurses to PATH #65572

Merged
merged 2 commits into from Jul 30, 2019
Merged

aerc: 0.1.4 -> 0.2.1; add ncurses to PATH #65572

merged 2 commits into from Jul 30, 2019

Conversation

AluisioASG
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aerc needs infocmp when running in terminals not in its database, hence the ncurses dependency.

@AluisioASG
aerc: add dependency on ncurses for unknown terminals
6791213 
The TUI library aerc uses, tcell, comes with a built-in database of
terminal definitions.  For terminals not in this database (e.g.
Alacritty), an entry is generated dynamically using infocmp, part of
ncurses' dev output.
@AluisioASG
aerc: 0.1.4 -> 0.2.1
14ce9b2
@ofborg ofborg bot requested a review from kalbasit July 29, 2019 21:31
@kalbasit
Copy link
Member

@GrahamcOfBorg build aerc

mmahut
mmahut approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • run nix-review without any failures
  • run and tested the binaries

@aanderse
Copy link
Member

What binary from ncurses.dev is this program using?

@AluisioASG
Copy link
Contributor Author

@aanderse infocmp, which aerc's TUI library uses to convert terminfo files to its own format.

@aanderse
Copy link
Member

Thanks @AluisioASG!

Looks straight forward enough to me. Merging based on the good word of @mmahut.

@aanderse aanderse merged commit f94d37c into NixOS:master Jul 30, 2019
@AluisioASG AluisioASG deleted the aerc branch July 30, 2019 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AluisioASG @kalbasit @aanderse @mmahut