Can you make libsForQt5.fcitx-qt5 use mkDerivaiton instead of stdenv.mkDerivation?

With that this change should be good to merge.

@GrahamcOfBorg build libsForQt5.fcitx-qt5 fcitx-engines.libpinyin

did you see my comment #65547 (comment), setting qmakeFlags+=" PLUGINDIR=$out/$qtPluginPrefix" can replace

substituteInPlace platforminputcontext/cmake_install.cmake \
     --replace ${qtbase.out} $out

in my short experiment and looks cleaner than a substitute. Maybe qt5.mkDerivation should set it as well.

in all honesty, i didn't. I made the PR before I saw the issue.

I've actually iterated off variants of what you've suggested @teto and that didn't actually fix it.
I'd prefer an actual patch for this, but I think this should be fine since it's consistent with what's done in other packages like this.

thanks for the fix, I am quite busy now so I just merged it, I will try to push my small fix (first making sure it's a fix xD) later on.

This build doesn't seem fixed for me, it still fails. When both .out and .bin are substituted it works fine though.

This build doesn't seem fixed for me, it still fails. When both .out and .bin are substituted it works fine though.

I've checked this PR out again locally and the build succeeds for me with
nix-build -A libsForQt5.fcitx-qt5 --check.

But on 525eaf407d4 it does appear broken again,
and that's pretty weird.

Adding another substitution did the trick though

diff --git a/pkgs/tools/inputmethods/fcitx/fcitx-qt5.nix b/pkgs/tools/inputmethods/fcitx/fcitx-qt5.nix
index ad5b4669498..697c02ee6ab 100644
--- a/pkgs/tools/inputmethods/fcitx/fcitx-qt5.nix
+++ b/pkgs/tools/inputmethods/fcitx/fcitx-qt5.nix
@@ -23,7 +23,8 @@ mkDerivation rec {
 
   preInstall = ''
     substituteInPlace platforminputcontext/cmake_install.cmake \
-      --replace ${qtbase.bin} $out
+      --replace ${qtbase.bin} $out \
+      --replace ${qtbase.out} $out
     substituteInPlace quickphrase-editor/cmake_install.cmake \
       --replace ${fcitx} $out
   '';

I'd say it would be best if @teto corrects this or apply the above diff.