Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.python-vipaccess: init at 0.10.3 #65570

Merged
merged 2 commits into from Aug 5, 2019

Conversation

herrwiese
Copy link
Contributor

Motivation for this change

python-vipaccess is a free and open source software (FOSS) implementation of Symantec's VIP Access client. This, for example, allows provisioning TOTP on PayPal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that oath tests succeed and builds appropriately.

Following comments are just expression style.

pkgs/development/python-modules/oath/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/oath/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/oath/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

Made a report upstream about fixing up the tests dlenski/python-vipaccess#30.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@worldofpeace worldofpeace merged commit 838bb4c into NixOS:master Aug 5, 2019
@herrwiese herrwiese deleted the python-vipaccess branch August 5, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants