Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udisks: 2.8.2 -> 2.8.4 #65578

Merged
merged 1 commit into from Jul 30, 2019
Merged

udisks: 2.8.2 -> 2.8.4 #65578

merged 1 commit into from Jul 30, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

https://github.com/storaged-project/udisks/releases/tag/udisks-2.8.3
https://github.com/storaged-project/udisks/releases/tag/udisks-2.8.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
binary works
enabled tests 👍

[28 built, 272 copied (916.4 MiB), 340.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/65578
21 package were build:
atom atom-beta cantata clementine clementineUnfree deepin.dde-file-manager far2l gvfs gnome3.gnome-control-center gnome3.gnome-disk-utility gnome3.gvfs hal-flash psensor rabbitvcs rapid-photo-downloader spaceFM udiskie udisks usermount xfce.gigolo xfce.gvfs

@FRidh FRidh merged commit 05f8fe7 into NixOS:master Jul 30, 2019
@JohnAZoidberg JohnAZoidberg deleted the udisks284 branch July 30, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohnAZoidberg @jonringer @FRidh