Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

croc: init at 6.1.1 #65622

Merged
merged 2 commits into from Aug 1, 2019
Merged

croc: init at 6.1.1 #65622

merged 2 commits into from Aug 1, 2019

Conversation

HugoReeves
Copy link
Member

Motivation for this change

This is my first PR to anything Nix. Croc is a golang cli tool that I use frequently when setting up new devices and it is not currently present within nixpkgs. Croc sends files securely use PAKE between two devices. I have added the derivation for croc v6.1.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

N/A

@HugoReeves HugoReeves changed the title Added github.com/schollz/croc derivation croc: init at 6.1.1 Jul 31, 2019
@ofborg ofborg bot requested a review from kalbasit July 31, 2019 05:11
worldofpeace
worldofpeace suggested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself to the maintainers list in a separate commit like

maintainers: add hugoreeves

pkgs/tools/networking/croc/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/croc/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/croc/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/croc/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/croc/default.nix Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

Tested sending a file successfully on NixOS.

@HugoReeves
Copy link
Member Author

@worldofpeace I have attempted (hopefully successfully) to make all of the changes you suggested. Thanks for your review.

@worldofpeace
Copy link
Contributor

Ah I don't think I explained #65622 (comment) properly.

buildGoModule sets platforms automatically to go.meta.platforms. So in most cases it's unneeded.

@HugoReeves
Copy link
Member Author

@worldofpeace I have removed the go.meta.platforms statement from the derivation, as I understand it this is the correct choice. I have also made the adjustments to the go.meta.longDescription statement.

worldofpeace
worldofpeace approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash that final commit and we can merge 👍

@HugoReeves
Copy link
Member Author

@worldofpeace Squashed 👍

@worldofpeace worldofpeace merged commit 3b37b0a into NixOS:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HugoReeves @worldofpeace @Janik-Haag