networkmanager: match pre-meson pre-upgrade behavior more closely #60904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I don't have a great way to share this information
as a link or something, haha, but try something
like the following to see what's changed:
Particularly look at the post-configure dump of options.
The version was changed as well, but even so it's unclear
how many of these changes were intentional or desirable.
Beyond the values in these commits, changes that may
be worth discussing/revisitng:
--disable-more-warnings
which doesn't trivially map (I don't think) but now we're end up
with "more-logging: true" instead of "more-logging: no" and
"more-asserts: 100" instead of "more-asserts: 0".
I don't know this is bad or not but let's just make sure
these are set as we'd like :).
We added a number of deps that also enable features/changes
but since they were blatant in the diff (add arg, add to buildInputs, etc)
these are presumably what we want (but confirmation would be good).
Related PRs and such:
sed
)Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)