Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager: match pre-meson pre-upgrade behavior more closely #60904

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 4, 2019

Motivation for this change

I don't have a great way to share this information
as a link or something, haha, but try something
like the following to see what's changed:

$ vim -d <(nix log -f channel:nixos-unstable networkmanager) <(nix log -f channel:nixos-19.03 networkmanager)

Particularly look at the post-configure dump of options.
The version was changed as well, but even so it's unclear
how many of these changes were intentional or desirable.

Beyond the values in these commits, changes that may
be worth discussing/revisitng:

  • asserts and warnings -- we used to specify --disable-more-warnings
    which doesn't trivially map (I don't think) but now we're end up
    with "more-logging: true" instead of "more-logging: no" and
    "more-asserts: 100" instead of "more-asserts: 0".
    I don't know this is bad or not but let's just make sure
    these are set as we'd like :).

We added a number of deps that also enable features/changes
but since they were blatant in the diff (add arg, add to buildInputs, etc)
these are presumably what we want (but confirmation would be good).

Related PRs and such:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
Copy link
Contributor

hedning commented May 21, 2019

Seems reasonable to me 👍

@dtzWill
Copy link
Member Author

dtzWill commented May 31, 2019

(no worries but I'm not likely to have time to see this through in the near future-- if someone's blocking on this please feel free to commandeer this and with my full blessing :))

@worldofpeace
Copy link
Contributor

followed up in #65624 which is current

@dtzWill
Copy link
Member Author

dtzWill commented Aug 1, 2019

Awesome, thanks for helping wrap these up! My hero! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants