Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PULL_REQUEST_TEMPLATE: Add "Notify maintainers" section #65581

Merged
merged 1 commit into from Jul 30, 2019
Merged

PULL_REQUEST_TEMPLATE: Add "Notify maintainers" section #65581

merged 1 commit into from Jul 30, 2019

Conversation

steshaw
Copy link
Member

@steshaw steshaw commented Jul 29, 2019

Motivation for this change

I thought this would be a helpful reminder.

Things done

These items do not apply.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Unsure

@steshaw
Copy link
Member Author

steshaw commented Jul 29, 2019

@worldofpeace, I'm not sure who are the maintainers of PULL_REQUEST_TEMPLATE. Sorry to bug you but could you help out? 🙏

@worldofpeace
Copy link
Contributor

I'm not sure who are the maintainers of PULL_REQUEST_TEMPLATE. Sorry to bug you but could you help out?

Typically anyone who uses the PULL_REQUEST_TEMPLATE chimes in on a change like this.

(last time that did include me #58098)

There's currently so many ways to notify people, i.e maintainers in meta get automatically pinged by ofborg but I typically do this exact thing like

blah blah beginning of pr template

---

cc @someone

so I don't see a reason why not to encourage people to actively find people to look after their change in this sense.

@steshaw
Copy link
Member Author

steshaw commented Jul 29, 2019

Thanks. I didn't realise that maintainers are automatically notified by the ofborg bot. There's a reference in the nixpkgs manual to explicitly notify maintainers. This may have been before ofborg was in action.

No one is listed in CODEOWNERS for PULL_REQUEST_TEMPLATE or .github.

I wonder if the manual should be updated instead.

@worldofpeace
Copy link
Contributor

I think it would be a good idea for someone to be listed in CODEOWNERS for those files.

And the manual is in fact correct in this matter, people should always notify someone of their changes.

@worldofpeace
Copy link
Contributor

Added some people who should be able to give you some feedback.

infinisil
infinisil approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FRidh FRidh merged commit e2a28e8 into NixOS:master Jul 30, 2019
@steshaw steshaw deleted the notify-maintainers branch July 30, 2019 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@samueldr samueldr Awaiting requested review from samueldr

@alyssais alyssais Awaiting requested review from alyssais

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@steshaw @worldofpeace @infinisil @FRidh