Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gn: 20190726 -> 20190403 (downgrade to fix Chromium) #65587

Merged
merged 1 commit into from Jul 30, 2019
Merged

gn: 20190726 -> 20190403 (downgrade to fix Chromium) #65587

merged 1 commit into from Jul 30, 2019

Conversation

lopsided98
Copy link
Contributor

Upstream knowingly broke compatibility with Chromium (https://gn-review.googlesource.com/c/gn/+/4980). Instead of the latest commit, we should use the version specified in the Chromium repository, as is done by Arch Linux: https://git.archlinux.org/svntogit/packages.git/tree/trunk/chromium-gn-version.sh?h=packages/gn

I am currently building Chromium.

cc @delroth

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lopsided98
gn: 20190726 -> 20190403
8c73d4b 
Downgrade to fix Chromium.
@lopsided98 lopsided98 mentioned this pull request Jul 30, 2019
Merged
10 tasks
@ofborg ofborg bot requested a review from matthewbauer July 30, 2019 02:52
@Mic92 Mic92 merged commit 362c9c4 into NixOS:master Jul 30, 2019
@lopsided98 lopsided98 deleted the gn-update branch August 27, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @Mic92