Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abbaye-des-morts: init at 2.0.1 #62124

Merged
merged 1 commit into from Jun 1, 2019
Merged

abbaye-des-morts: init at 2.0.1 #62124

merged 1 commit into from Jun 1, 2019

Conversation

marius851000
Copy link
Contributor

Motivation for this change

A fun game I discovered and wanted to play. Packaged it BTW.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmahut
mmahut requested changes May 27, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg eval succeeded
  • run nix-review without any failures
  • run and tested the binaries

pkgs/games/abbaye-des-morts/default.nix Show resolved Hide resolved
@matthewbauer
Copy link
Member

@GrahamcOfBorg build abbaye-des-morts

@marius851000
Copy link
Contributor Author

I don't know how to solve this mac problem...

@marius851000
Copy link
Contributor Author

How can I test with clang ?

@mmahut
Copy link
Member

mmahut commented May 28, 2019

I don't know how to solve this mac problem...

If you are not able to solve this for darwin, you need to specify the platforms as per https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

@marius851000
Copy link
Contributor Author

I've corrected the problem with mac

@c0bw3b
Copy link
Contributor

c0bw3b commented May 29, 2019

@GrahamcOfBorg build abbaye-des-morts

@marius851000
Copy link
Contributor Author

it doesn't appear to be a problem coming from me

@fpletz
Copy link
Member

fpletz commented Jun 1, 2019

Since the mac building the package seems to have been our of resources:

@GrahamcOfBorg build abbaye-des-morts

fpletz
fpletz approved these changes Jun 1, 2019
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@fpletz fpletz merged commit ac6e484 into NixOS:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut requested changes

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marius851000 @matthewbauer @mmahut @c0bw3b @fpletz